Add provider of updates as a dimension to metrics. #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6199 +/- ##
=============================================
+ Coverage 69.91% 69.92% +0.01%
- Complexity 17736 17742 +6
=============================================
Files 2006 2007 +1
Lines 75526 75567 +41
Branches 7730 7730
=============================================
+ Hits 52804 52843 +39
- Misses 20036 20038 +2
Partials 2686 2686 ☔ View full report in Codecov by Sentry. |
...ation/src/main/java/org/opentripplanner/updater/trip/metrics/StreamingTripUpdateMetrics.java
Outdated
Show resolved
Hide resolved
t2gran
requested changes
Nov 4, 2024
application/src/main/java/org/opentripplanner/model/RealTimeTripUpdate.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/opentripplanner/updater/siri/AddedTripBuilderTest.java
Outdated
Show resolved
Hide resolved
...opentripplanner/standalone/config/routerconfig/updaters/SiriETGooglePubsubUpdaterConfig.java
Outdated
Show resolved
Hide resolved
…ipUpdateMetrics. Also adds more details to the new producerMetrics flag, and renames it from detailedMetrics.
...in/java/org/opentripplanner/standalone/config/routerconfig/updaters/SiriETUpdaterConfig.java
Outdated
Show resolved
Hide resolved
...opentripplanner/standalone/config/routerconfig/updaters/SiriETGooglePubsubUpdaterConfig.java
Outdated
Show resolved
Hide resolved
...opentripplanner/standalone/config/routerconfig/updaters/SiriETGooglePubsubUpdaterConfig.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/updater/siri/AddedTripBuilder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/updater/spi/DataValidationExceptionMapper.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/updater/trip/UrlUpdaterParameters.java
Show resolved
Hide resolved
...ation/src/main/java/org/opentripplanner/updater/trip/metrics/StreamingTripUpdateMetrics.java
Show resolved
Hide resolved
...ation/src/main/java/org/opentripplanner/updater/trip/metrics/StreamingTripUpdateMetrics.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
approved these changes
Nov 6, 2024
t2gran
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the provider (datasource for SIRI updates) as a dimension to some of the metrics from the realtime updater system. The added detail on the metrics can be enabled in the configuration for the realtime updater.
Issue
Closes #4656
Unit tests
Updated existing unit tests to work with new provider and ran locally to make sure updates are applied as expected.
Documentation
Documented the new flag that enables the detailed metrics.